Skip to content

Lpa 23#53

Merged
mcquenji merged 4 commits intomainfrom
lpa-23
Jan 4, 2026
Merged

Lpa 23#53
mcquenji merged 4 commits intomainfrom
lpa-23

Conversation

@mcquenji
Copy link
Contributor

@mcquenji mcquenji commented Oct 12, 2025

No description provided.

@mcquenji mcquenji linked an issue Oct 12, 2025 that may be closed by this pull request
Move backlog toggle to a more intuitive spot #52
Closed
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 12, 2025 •
edited
Loading

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Summary by CodeRabbit

  • Bug Fixes

    • Fixed daylight saving time calculation issues in calendar planning.
    • Fixed text overflow in kanban cards with improved text wrapping.

  • New Features

    • Improved backlog toggle accessibility in kanban interface.
    • Added secure state restoration support for macOS app.

  • Chores

    • Updated build system and macOS deployment configuration.

✏️ Tip: You can customize this high-level summary in your review settings.

Walkthrough

This PR updates a Flutter macOS project with git ignore patterns, fixes a daylight saving time issue in calendar date calculations, refactors the kanban backlog toggle UI, adds text overflow handling to kanban card text elements, and integrates CocoaPods build system support across macOS project configuration, Xcode project settings, and Swift AppDelegate initialization.

Changes

Cohort / File(s) Summary
Git Configuration
.gitignore		 Adds .build/ and .swiftpm/ directories to ignore patterns.
Flutter UI — Calendar & Kanban
lib/src/calendar/presentation/screens/plan_screen.dart, lib/src/kanban/presentation/screens/kanban_screen.dart, lib/src/kanban/presentation/widgets/kanban_card.dart		 (1) Fixes DST bug by replacing date arithmetic with explicit day-copying via copyWith(day:) in calendar; (2) Refactors kanban backlog toggle from inline UI to dedicated _BacklogToggle widget registered in TitleBar via didChangeDependencies; (3) Adds ellipsis overflow handling and flexible layout to task name, status, deadline, and planned-on text elements in kanban cards.
macOS Build System — CocoaPods & Xcode
macos/Flutter/Flutter-Debug.xcconfig, macos/Flutter/Flutter-Release.xcconfig, macos/Podfile, macos/Runner.xcodeproj/project.pbxproj, macos/Runner.xcodeproj/xcshareddata/xcschemes/Runner.xcscheme, macos/Runner.xcworkspace/contents.xcworkspacedata		 Integrates CocoaPods into macOS build pipeline: adds optional/required Pods xcconfig includes in build configurations, creates new Podfile with platform 10.15 and runner target setup, injects Pods framework references and build phases (manifest check, embed frameworks) into Xcode project, adds GPU validation mode to launch scheme, and includes Pods project in workspace.
macOS Swift Runtime
macos/Runner/AppDelegate.swift		 Updates AppDelegate entry point annotation from @NSApplicationMain to @main and adds applicationSupportsSecureRestorableState(_:) override returning true.

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~45 minutes

Poem

🐰 With builds now safe from daylight's trick,
and text that flows without a glitch,
the Mac takes shape with pods at hand,
while toggles dance as code commands—
this fluffy change, from swift to screen! ✨

✨ Finishing touches
  • 📝 Generate docstrings
📜 Recent review details

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ee5f483 and f5d44b4.

⛔ Files ignored due to path filters (1)
  • macos/Podfile.lock is excluded by !**/*.lock
📒 Files selected for processing (11)
  • .gitignore
  • lib/src/calendar/presentation/screens/plan_screen.dart
  • lib/src/kanban/presentation/screens/kanban_screen.dart
  • lib/src/kanban/presentation/widgets/kanban_card.dart
  • macos/Flutter/Flutter-Debug.xcconfig
  • macos/Flutter/Flutter-Release.xcconfig
  • macos/Podfile
  • macos/Runner.xcodeproj/project.pbxproj
  • macos/Runner.xcodeproj/xcshareddata/xcschemes/Runner.xcscheme
  • macos/Runner.xcworkspace/contents.xcworkspacedata
  • macos/Runner/AppDelegate.swift

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@mcquenji mcquenji linked an issue Oct 12, 2025 that may be closed by this pull request
fix overflow in kanban card #51
Closed
@necodeit
Copy link

necodeit bot commented Oct 12, 2025

Analysis Report for f5d44b4

  • Infos: 11
  • Warnings: 1
  • Errors: 0
Click to see the full report 
warning • A value for optional parameter 'key' isn't ever given • lib/src/kanban/presentation/screens/kanban_screen.dart:95:31 • unused_element_parameter
info • The value of the argument is redundant because it matches the default value • lib/src/slots/presentation/screens/slot_reservation_screen.dart:51:38 • avoid_redundant_argument_values
info • Missing documentation for a public member • lib/src/slots/presentation/widgets/mapping_widget.dart:6:7 • public_member_api_docs
info • Missing documentation for a public member • lib/src/slots/presentation/widgets/mapping_widget.dart:7:9 • public_member_api_docs
info • Missing documentation for a public member • lib/src/slots/presentation/widgets/mapping_widget.dart:9:22 • public_member_api_docs
info • Missing documentation for a public member • lib/src/slots/presentation/widgets/mapping_widget.dart:11:17 • public_member_api_docs
info • The value of the argument is redundant because it matches the default value • lib/src/slots/presentation/widgets/mapping_widget.dart:22:85 • avoid_redundant_argument_values
info • Missing documentation for a public member • lib/src/slots/presentation/widgets/slot_data_pop_over.dart:6:7 • public_member_api_docs
info • Missing documentation for a public member • lib/src/slots/presentation/widgets/slot_data_pop_over.dart:7:9 • public_member_api_docs
info • Missing documentation for a public member • lib/src/slots/presentation/widgets/slot_data_pop_over.dart:9:22 • public_member_api_docs
info • The value of the argument is redundant because it matches the default value • lib/src/slots/presentation/widgets/slot_data_pop_over.dart:88:38 • avoid_redundant_argument_values
info • The value of the argument is redundant because it matches the default value • lib/src/slots/presentation/widgets/slot_data_pop_over.dart:91:47 • avoid_redundant_argument_values

View annotated files

@mcquenji mcquenji linked an issue Oct 12, 2025 that may be closed by this pull request
fix overflow in notification widget #50
Closed
@mcquenji mcquenji marked this pull request as ready for review January 4, 2026 15:43
@mcquenji mcquenji merged commit 8b93f6a into main Jan 4, 2026
0 of 4 checks passed
@mcquenji mcquenji deleted the lpa-23 branch January 4, 2026 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Move backlog toggle to a more intuitive spot fix overflow in kanban card fix overflow in notification widget

2 participants

@mcquenji @MasterMarcoHD